Skip to content

Conversation

@rriveramcrus
Copy link

Modifies the stm32f4xx HAL files to add support for the STM32F401xD family of devices. Since STM32F401xE family shares a datasheet with the STM32F401xD family, they are assumed to be similar enough to share the HAL code.

Special attention should be given to the changes made to stm32cube/stm32f4xx/drivers/include/stm32f4xx_hal_flash_ex.h since this is where the D and E families may differ, but I expect the flash IP to be mostly the same.

Modifies the stm32f4xx HAL files to add support for the STM32F401xD family
of devices. Since STM32F401xE family shares a datasheet with the STM32F401xD
family, they are assumed to be similar enough to share the HAL code.

Signed-off-by: Ricardo Rivera-Matos <[email protected]>
@erwango
Copy link
Member

erwango commented Apr 25, 2025

@rriveramcrus We won't modify these files if the change is not acked beforehand by STM32Cube HAL owners in https://github.com/STMicroelectronics/STM32CubeF4.
So I suggest to raise your point first there.

On my side, I suspect that there is no dedicated define for STM32F401xD because indeed it is similar to STM32F401xE from HAL point of view and hence don't require a specific defined. STM32F401xE should be used instead. But I let F4 package onwers confirm.

I'll nack the change for now, but I'll change depending on HAL team feedback.

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@rriveramcrus
Copy link
Author

STMicroelectronics/STM32CubeF4#192
closing this based on the discussion here

@erwango
Copy link
Member

erwango commented May 9, 2025

@rriveramcrus We'll need to fix following line https://github.com/zephyrproject-rtos/zephyr/blob/b450c71e4cc083f19880fd36b0ec554b0a756ee0/soc/st/stm32/stm32f4x/Kconfig.soc#L107. Would you mind pushing this change ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants